linux-kernel - Re: [PATCH] Drivers: hv: vmbus: Check for ring when getting debug info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181218165542.GA2746@sasha-vm>
Date:   Tue, 18 Dec 2018 11:55:42 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     "'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        "'apw@...onical.com'" <apw@...onical.com>,
        "'olaf@...fle.de'" <olaf@...fle.de>,
        "'devel@...uxdriverproject.org'" <devel@...uxdriverproject.org>,
        vkuznets <vkuznets@...hat.com>,
        "'jasowang@...hat.com'" <jasowang@...hat.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Check for ring when getting debug
 info

On Mon, Dec 17, 2018 at 08:16:09PM +0000, Dexuan Cui wrote:
>
>fc96df16a1ce is good and can already fix the "return stack garbage" issue,
>but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
>return stack garbage, if people forget to check channel->state or
>ring_info->ring_buffer, when using the function in the future.
>
>Having an error check in the function would eliminate the potential risk.
>
>Add a Fixes tag to indicate the patch depdendency.
>
>Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels")
>Cc: stable@...r.kernel.org
>Cc: K. Y. Srinivasan <kys@...rosoft.com>
>Cc: Haiyang Zhang <haiyangz@...rosoft.com>
>Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
>Signed-off-by: Dexuan Cui <decui@...rosoft.com>
>---
>
>*NOTE*: the patch is based on char-misc's char-misc-linus branch.

Queued up, thank you.

--
Thanks,
Sasha