linux-kernel - Re: [PATCH v4 2/2] trace nvme submit queue status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Dec 2018 10:26:46 -0700
From:   Keith Busch <keith.busch@...el.com>
To:     yupeng <yupeng0921@...il.com>
Cc:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>
Subject: Re: [PATCH v4 2/2] trace nvme submit queue status

On Mon, Dec 17, 2018 at 08:51:38PM -0800, yupeng wrote:
> +TRACE_EVENT(nvme_sq,
> +	TP_PROTO(void *rq_disk, int qid, int sq_head, int sq_tail),
> +	TP_ARGS(rq_disk, qid, sq_head, sq_tail),
> +	TP_STRUCT__entry(
> +		__array(char, disk, DISK_NAME_LEN)
> +		__field(int, qid)
> +		__field(int, sq_head)
> +		__field(int, sq_tail)
> +	),
> +	TP_fast_assign(
> +		__assign_disk_name(__entry->disk, rq_disk);
> +		__entry->qid = qid;
> +		__entry->sq_head = sq_head;
> +		__entry->sq_tail = sq_tail;
> +	),
> +	TP_printk("nvme: %s qid=%d head=%d tail=%d",
> +		__print_disk_name(__entry->disk),

No need for a space after the %s. __print_disk_name already appends a
space if there's a disk name, and we don't want the extra space if there
isn't one. Also, every other nvme trace has a ',' after each entry. Not
a big deal, just minor format consistency.