linux-kernel - Re: [PATCH V4 1/3] misc/pvpanic: return 0 for empty body registerfunction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181219065621.GA21256@kroah.com>
Date:   Wed, 19 Dec 2018 07:56:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     peng.hao2@....com.cn
Cc:     arnd@...db.de, andy.shevchenko@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 1/3]  misc/pvpanic: return 0 for empty body
 registerfunction

On Wed, Dec 19, 2018 at 08:11:37AM +0800, peng.hao2@....com.cn wrote:
> >On Tue, Dec 18, 2018 at 05:46:41PM +0800, Peng Hao wrote:
> >> Return 0 for empty body register function normally.
> >>
> >> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
> >> ---
> >> QEMU community requires additional PCI devices to simulate PVPANIC devices
> >> so that some architectures can not occupy precious less than 4G of memory
> >> space.
> >
> >What is this for below the --- line?
> >
> >And again, you did not specify what changed from the previous versions.
> >I can not take these unless you provide it.
> 
> The previous version of the code is basically unchanged, and the new patches just 
> adds a PCI interface. Previous versions only support ACPI and FDT interfaces.
> The QEMU community requires a PCI interface so that some architectures do not occupy
>  precious low 4G memory address.

No, you are changing things between each version, hopefully based on the
review comments.  And the testing that is being provided for you showing
you where your code breaks the build.

That goes in the "what changed" lines, as is documented in the kernel
documentation.  Please follow that when resubmitting if you wish for
your changes to be able to be accepted.

thanks,

greg k-h