linux-kernel - Re: [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1616107.XVYD9PJAcy@acerlaptop>
Date:   Wed, 19 Dec 2018 12:26:16 +0100
From:   Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonathan Bakker <xc-racer2@...e.ca>
Subject: Re: [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading

Dnia środa, 19 grudnia 2018 00:49:49 CET Marcel Holtmann pisze:
> Hi Pawel,
> 
> > The Broadcom controller on aries S5PV210 boards sends out a couple of
> > unknown packets after the firmware is loaded.  This will cause
> > logging of errors such as:
> > 	Bluetooth: hci0: Frame reassembly failed (-84)
> > 
> > This is probably also the case with other boards, as there are related
> > Android userspace patches for custom ROMs such as
> > https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/142721/
> > Since this appears to be intended behaviour, treated them as diagnostic
> > packets.
> > 
> > Note that this is another variant of commit 01d5e44ace8a
> > ("Bluetooth: hci_bcm: Handle empty packet after firmware loading")
> > 
> > Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca>
> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> > 
> > ---
> > Changes from v1:
> > 	- Rename UNKNOWN to TYPE49
> > 	- Rename UNKNOWN2 to TYPE52
> > ---
> > drivers/bluetooth/hci_bcm.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> 
> can you update this patch against latest bluetooth-next tree since it no longer applies cleanly.
I've send new version of both patches (this and Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading), rebased against latest bluetooth-next.
> 
> Regards
> 
> Marcel
>