linux-kernel - Re: [PATCH 2/7] drm: Remove use of drm_mode_object

Open Source and information security mailing list archives

Date:   Wed, 19 Dec 2018 14:11:19 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Shayenne Moura <shayenneluzmoura@...il.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/7] drm: Remove use of drm_mode_object

On Tue, Dec 18, 2018 at 11:38:10AM -0200, Shayenne Moura wrote:
> This patch removes the drm_mode_object prints, evaluation and use from 
> drm_display_mode objects used in drm files. It removes dependency from
> drm_mode_object.
> 
> Signed-off-by: Shayenne Moura <shayenneluzmoura@...il.com>

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
> ---
>  drivers/gpu/drm/drm_crtc_helper.c | 5 ++---
>  drivers/gpu/drm/drm_modes.c       | 9 ---------
>  2 files changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index a3c81850e755..cc5cc8d109a2 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -386,9 +386,8 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
>  		if (!encoder_funcs)
>  			continue;
>  
> -		DRM_DEBUG_KMS("[ENCODER:%d:%s] set [MODE:%d:%s]\n",
> -			encoder->base.id, encoder->name,
> -			mode->base.id, mode->name);
> +		DRM_DEBUG_KMS("[ENCODER:%d:%s] set [MODE:%s]\n",
> +			encoder->base.id, encoder->name, mode->name);
>  		if (encoder_funcs->mode_set)
>  			encoder_funcs->mode_set(encoder, mode, adjusted_mode);
>  
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 24a750436559..adce9a26bac9 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -71,11 +71,6 @@ struct drm_display_mode *drm_mode_create(struct drm_device *dev)
>  	if (!nmode)
>  		return NULL;
>  
> -	if (drm_mode_object_add(dev, &nmode->base, DRM_MODE_OBJECT_MODE)) {
> -		kfree(nmode);
> -		return NULL;
> -	}

With this we stop filing out base.id and base.type, so this patch should
be reordered in the series to be after all users of these fields are gone
from drivers. But before the last patch that removes these fields.

Thanks, Daniel

> -
>  	return nmode;
>  }
>  EXPORT_SYMBOL(drm_mode_create);
> @@ -92,8 +87,6 @@ void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode)
>  	if (!mode)
>  		return;
>  
> -	drm_mode_object_unregister(dev, &mode->base);
> -
>  	kfree(mode);
>  }
>  EXPORT_SYMBOL(drm_mode_destroy);
> @@ -911,11 +904,9 @@ EXPORT_SYMBOL(drm_mode_set_crtcinfo);
>   */
>  void drm_mode_copy(struct drm_display_mode *dst, const struct drm_display_mode *src)
>  {
> -	int id = dst->base.id;
>  	struct list_head head = dst->head;
>  
>  	*dst = *src;
> -	dst->base.id = id;
>  	dst->head = head;
>  }
>  EXPORT_SYMBOL(drm_mode_copy);
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives