linux-kernel - Re: [PATCH 09/41] scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d5684c5-7b09-3e4a-d0ad-a024e3d06d05@embeddedor.com>
Date:   Wed, 19 Dec 2018 09:38:46 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Anil Gurumurthy <anil.gurumurthy@...gic.com>,
        Sudarsana Kalluru <sudarsana.kalluru@...gic.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/41] scsi: bfa: bfa_fcpim: Mark expected switch
 fall-throughs

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that I replaced "Fall through !!!" with a "fall through"
> annotation, which is what GCC is expecting to find.
> 
> Addresses-Coverity-ID: 114971 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>   drivers/scsi/bfa/bfa_fcpim.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c
> index 2c85f5b1f9c1..7e996bcf026c 100644
> --- a/drivers/scsi/bfa/bfa_fcpim.c
> +++ b/drivers/scsi/bfa/bfa_fcpim.c
> @@ -2586,6 +2586,7 @@ bfa_ioim_send_ioreq(struct bfa_ioim_s *ioim)
>   	case FCP_IODIR_RW:
>   		bfa_stats(itnim, input_reqs);
>   		bfa_stats(itnim, output_reqs);
> +		/* fall through */
>   	default:
>   		bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa));
>   	}
> @@ -2820,6 +2821,7 @@ bfa_ioim_isr(struct bfa_s *bfa, struct bfi_msg_s *m)
>   
>   	case BFI_IOIM_STS_TIMEDOUT:
>   		bfa_stats(ioim->itnim, iocomp_timedout);
> +		/* fall through */
>   	case BFI_IOIM_STS_ABORTED:
>   		rsp->io_status = BFI_IOIM_STS_ABORTED;
>   		bfa_stats(ioim->itnim, iocomp_aborted);
> @@ -3215,9 +3217,7 @@ bfa_tskim_sm_cleanup_qfull(struct bfa_tskim_s *tskim,
>   	switch (event) {
>   	case BFA_TSKIM_SM_DONE:
>   		bfa_reqq_wcancel(&tskim->reqq_wait);
> -		/*
> -		 * Fall through !!!
> -		 */
> +		/* fall through */
>   	case BFA_TSKIM_SM_QRESUME:
>   		bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup);
>   		bfa_tskim_send_abort(tskim);
>