linux-kernel - Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Dec 2018 16:48:52 +0100
From:   David Lechner <david@...hnology.com>
To:     Roger Quadros <rogerq@...com>, Mark Brown <broonie@...nel.org>
Cc:     ohad@...ery.com, bjorn.andersson@...aro.org, tony@...mide.com,
        robh+dt@...nel.org, bcousson@...libre.com, ssantosh@...nel.org,
        s-anna@...com, nsekhar@...com, t-kristo@...com, nsaulnier@...com,
        jreeder@...com, m-karicheri2@...com, woods.technical@...il.com,
        linux-omap@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support



On 12/19/18 4:43 PM, Roger Quadros wrote:
> On 19/12/18 14:38, Mark Brown wrote:
>> On Tue, Dec 18, 2018 at 05:51:12PM +0200, Roger Quadros wrote:
>>
>>> We could combine control and debug into one iomap and use
>>> 2 regmap ranges. But this is really working around the
>>> regmap_mmio limitation of not being able to use more than one ioremaps.
>>
>>> Mark, any suggestions?
>>
>> If they're separate regions why not create separate regmaps for them?
>>
> 
> I tried that but only the first regmap shows up in debugfs.
> 
> e.g.
> 
> +
> +       pru->ctrl_regmap = devm_regmap_init_mmio(dev, pru->iomem_regions[PRU_IOMEM_CTRL].va,
> +                                                &pru_regmap_config);
> +       if (IS_ERR(pru->ctrl_regmap)) {
> +               ret = PTR_ERR(pru->ctrl_regmap);
> +               dev_err(dev, "CTRL regmap init failed: %d\n", ret);
> +               goto free_rproc;
> +       }
> +
> +
> +       pru->debug_regmap = devm_regmap_init_mmio(dev, pru->iomem_regions[PRU_IOMEM_DEBUG].va,
> +                                                 &pru_debug_regmap_config);
> +       if (IS_ERR(pru->debug_regmap)) {
> +               ret = PTR_ERR(pru->debug_regmap);
> +               dev_err(dev, "DEBUG regmap init failed: %d\n", ret);
> +               goto free_rproc;
>          }
> 
> 
> Did I do something wrong or we just need to enhance regmap_debugfs.c?

Do you assign the name field in pru_regmap_config and 
pru_debug_regmap_config?