linux-kernel - Re: [PATCH 4/7] drm: i915: Delete base.id prints

Open Source and information security mailing list archives

Date:   Wed, 19 Dec 2018 19:27:00 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Shayenne Moura <shayenneluzmoura@...il.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints

On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura
<shayenneluzmoura@...il.com> wrote:
>
> On 12/19, Daniel Vetter wrote:
> > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > > This patch removes base.id prints from drm_display_mode
> > > objects in i915 files. It removes dependency from drm_mode_object.
> > >
> > > Signed-off-by: Shayenne Moura <shayenneluzmoura@...il.com>
> >
> > Again I think better to switch to DRM_MODE_FMT/ARG.
> > -Daniel
> >
>
> This one has a different print style. Is it okay to change to DRM_MODE_FMT?

Yeah, standardizing sounds good, just mention in the commit message if
something has changed. This is all debug information, so no issue if
we change the output format slightly.
-Daniel

>
> Best,
> Shayenne
> > > ---
> > >  drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 7f455bca528e..61dd7bb3fa85 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > >     for (i = 0; i < tabs; i++)
> > >             seq_putc(m, '\t');
> > >
> > > -   seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > -              mode->base.id, mode->name,
> > > +   seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > +              mode->name,
> > >                mode->vrefresh, mode->clock,
> > >                mode->hdisplay, mode->hsync_start,
> > >                mode->hsync_end, mode->htotal,
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@...ts.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives