linux-kernel - Re: [PATCH] regulator: mcp16502: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181219184023.GM8130@sirena.org.uk>
Date:   Wed, 19 Dec 2018 18:40:23 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Andrei.Stefanescu@...rochip.com
Cc:     lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Cristian.Birsan@...rochip.com,
        Nicolas.Ferre@...rochip.com
Subject: Re: [PATCH] regulator: mcp16502: code cleanup

On Mon, Dec 17, 2018 at 11:44:59AM +0000, Andrei.Stefanescu@...rochip.com wrote:
> This patch does the following:
> - align parameter with parenthesis
> - fix compile error
> 
> If CONFIG_SUSPEND is not set the dummy pm_ops
> callbacks are named mcp16502_suspend and mcp16502_resume
> instead of mcp16502_suspend_noirq and mcp16502_resume_noirq.

Thanks for fixing this.

> 
> Excerpt from compile log (kbuild test robot):

There's no need to include the entire output from the kbuild robot in
your commit log, especially when it's much larger than either the change
or description of the change - it gets in the way of reading things as
it makes it harder to pick out relevant information.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)