linux-kernel - Re: [PATCH 1/2] ARC: show_regs: avoid page allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d58e8389-3e27-b1cf-7787-52808a0c22a7@synopsys.com>
Date:   Wed, 19 Dec 2018 13:36:43 -0800
From:   Vineet Gupta <vineet.gupta1@...opsys.com>
To:     William Kucharski <william.kucharski@...cle.com>
CC:     <linux-arch@...r.kernel.org>, <linux-mm@...ck.org>,
        Peter Zijlstra <peterz@...radead.org>,
        <linux-snps-arc@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARC: show_regs: avoid page allocator

On 12/19/18 12:46 PM, William Kucharski wrote:
> I would rather see 256 as a #define somewhere rather than a magic number sprinkled
> around arch/arc/kernel/troubleshoot.c.

That bothered me as well, but I was too lazy to define one and the existing ones
don't apply. PATH_MAX is 4K which will blow up the stack usage.
> 
> Still, that's what the existing code does, so I suppose it's OK.

I'll define one locally.

> Otherwise the change looks good.

Thx for taking a look.

> Reviewed-by: William Kucharski <william.kucharski@...cle.com>

I'll add this to the patch.

Thx,
-Vineet