linux-kernel - Re: [PATCH] xen/netfront: tolerate frags with no data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181218.220013.1743575331051422957.davem@davemloft.net>
Date:   Tue, 18 Dec 2018 22:00:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jgross@...e.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        xen-devel@...ts.xenproject.org, sstabellini@...nel.org,
        boris.ostrovsky@...cle.com, stable@...r.kernel.org
Subject: Re: [PATCH] xen/netfront: tolerate frags with no data

From: Juergen Gross <jgross@...e.com>
Date: Tue, 18 Dec 2018 16:06:19 +0100

> At least old Xen net backends seem to send frags with no real data
> sometimes. In case such a fragment happens to occur with the frag limit
> already reached the frontend will BUG currently even if this situation
> is easily recoverable.
> 
> Modify the BUG_ON() condition accordingly.
> 
> Tested-by: Dietmar Hahn <dietmar.hahn@...fujitsu.com>
> Signed-off-by: Juergen Gross <jgross@...e.com>

Applied and queued up for -stable.

But many of these BUG's in the driver should be converted to
WARNs and recovery code added.