linux-kernel - Re: [PATCHv2 01/12] acpi: Create subtable parsing infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4jmGH0FS8iBP9=A-nicNfgHAmU+nBHsGgxyS3RNZ9tV5Q@mail.gmail.com>
Date:   Wed, 19 Dec 2018 15:59:48 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Schmauss, Erik" <erik.schmauss@...el.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Busch, Keith" <keith.busch@...el.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Hansen, Dave" <dave.hansen@...el.com>
Subject: Re: [PATCHv2 01/12] acpi: Create subtable parsing infrastructure

On Wed, Dec 19, 2018 at 3:19 PM Schmauss, Erik <erik.schmauss@...el.com> wrote:
>
>
>
> > -----Original Message-----
> > From: linux-acpi-owner@...r.kernel.org [mailto:linux-acpi-
> > owner@...r.kernel.org] On Behalf Of Rafael J. Wysocki
> > Sent: Tuesday, December 11, 2018 1:45 AM
> > To: Busch, Keith <keith.busch@...el.com>
> > Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; ACPI Devel
> > Maling List <linux-acpi@...r.kernel.org>; Linux Memory Management List
> > <linux-mm@...ck.org>; Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org>; Rafael J. Wysocki <rafael@...nel.org>;
> > Hansen, Dave <dave.hansen@...el.com>; Williams, Dan J
> > <dan.j.williams@...el.com>
> > Subject: Re: [PATCHv2 01/12] acpi: Create subtable parsing infrastructure
> >
> > On Tue, Dec 11, 2018 at 2:05 AM Keith Busch <keith.busch@...el.com>
> > wrote:
> > >
>
> Hi Rafael and Bob,
>
> > > Parsing entries in an ACPI table had assumed a generic header
> > > structure that is most common. There is no standard ACPI header,
> > > though, so less common types would need custom parsers if they want go
> > > through their sub-table entry list.
> >
> > It looks like the problem at hand is that acpi_hmat_structure is incompatible
> > with acpi_subtable_header because of the different layout and field sizes.
>
> Just out of curiosity, why don't we use ACPICA code to parse static ACPI tables
> in Linux?
>
> We have a disassembler for static tables that parses all supported tables. This
> seems like a duplication of code/effort...

Oh, I thought acpi_table_parse_entries() was the common code. What's
the ACPICA duplicate?