linux-kernel - Re: [PATCH v5 01/15] KVM: s390: unregister debug feature on failing arch init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0a285681-19f1-6432-866a-636c6ea2e9c4@de.ibm.com>
Date:   Thu, 20 Dec 2018 08:55:49 +0100
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     mimu@...ux.ibm.com, Cornelia Huck <cohuck@...hat.com>
Cc:     KVM Mailing List <kvm@...r.kernel.org>,
        Linux-S390 Mailing List <linux-s390@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Halil Pasic <pasic@...ux.ibm.com>,
        Pierre Morel <pmorel@...ux.ibm.com>
Subject: Re: [PATCH v5 01/15] KVM: s390: unregister debug feature on failing
 arch init



On 20.12.2018 08:49, Michael Mueller wrote:
> 
> 
> On 19.12.18 21:10, Cornelia Huck wrote:
>> On Wed, 19 Dec 2018 20:17:42 +0100
>> Michael Mueller <mimu@...ux.ibm.com> wrote:
>>
>>> Make sure the debug feature and its allocated resources get
>>> released upon unsuccessful architecture initialization.
>>>
>>> A related indication of the issue will be reported as kernel
>>> message.
>>>
>>> Signed-off-by: Michael Mueller <mimu@...ux.ibm.com>
>>> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
>>> Reviewed-by: Pierre Morel <pmorel@...ux.ibm.com>
>>> Reviewed-by: David Hildenbrand <david@...hat.com>
>>> Message-Id: <20181130143215.69496-2-mimu@...ux.ibm.com>
>>> Signed-off-by: Christian Borntraeger <borntraeger@...ibm.com>
>>> ---
>>>   Documentation/kmsg/s390/kvm | 12 ++++++++++++
>>>   arch/s390/kvm/kvm-s390.c    | 17 ++++++++++++++---
>>>   2 files changed, 26 insertions(+), 3 deletions(-)
>>>   create mode 100644 Documentation/kmsg/s390/kvm
>>>
>>> diff --git a/Documentation/kmsg/s390/kvm b/Documentation/kmsg/s390/kvm
>>> new file mode 100644
>>> index 000000000000..76ffe2012254
>>> --- /dev/null
>>> +++ b/Documentation/kmsg/s390/kvm
>>> @@ -0,0 +1,12 @@
>>> +/*?
>>> + * Text: "Failed to register FLIC rc=%d\n"
>>> + * Severity: Error
>>> + * Parameter:
>>> + *   @1: return code of the FLIC registration call
>>> + * Description:
>>> + * The registration of the FLIC (Floating Interrupt Controller Interface)
>>> + * was not successful.
>>> + * User action:
>>> + * If this problem persists after a reload of the kvm kernel module, gather
>>> + * Linux debug data and contact your support organization.
>>> + */
>>
>> Hm, it seems that the kmsg stuff crept in there again...
>>
> 
> picked from wrong branch, sorry...
> 

FWIW, this patch without kmsg one is now part of kvm/next.

https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?h=next&id=308c3e6673b012beecb96ef04cc65f4a0e7cdd99