linux-kernel - Re: [PATCH] video: clps711x-fb: release disp device node in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Dec 2018 17:42:56 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Alexander Shiyan <shc_work@...l.ru>, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] video: clps711x-fb: release disp device node in probe()


[ added dri-devel ML to Cc: ]

On 11/02/2018 11:23 PM, Alexey Khoroshilov wrote:
> clps711x_fb_probe() increments refcnt of disp device node by
> of_parse_phandle() and leaves it undecremented on both
> successful and error paths.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Patch queued for 4.21, thanks.

> ---
>  drivers/video/fbdev/clps711x-fb.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index ff561073ee4e..42f909618f04 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -287,14 +287,17 @@ static int clps711x_fb_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = of_get_fb_videomode(disp, &cfb->mode, OF_USE_NATIVE_MODE);
> -	if (ret)
> +	if (ret) {
> +		of_node_put(disp);
>  		goto out_fb_release;
> +	}
>  
>  	of_property_read_u32(disp, "ac-prescale", &cfb->ac_prescale);
>  	cfb->cmap_invert = of_property_read_bool(disp, "cmap-invert");
>  
>  	ret = of_property_read_u32(disp, "bits-per-pixel",
>  				   &info->var.bits_per_pixel);
> +	of_node_put(disp);
>  	if (ret)
>  		goto out_fb_release;
>  

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics