linux-kernel - Re: [PATCH v3 04/19] mailbox: bcm-flexrm: Use device-managed registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2fd0c99-1000-618a-a81f-bacfd74b2271@broadcom.com>
Date:   Thu, 20 Dec 2018 09:46:43 -0800
From:   Scott Branden <scott.branden@...adcom.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jassi Brar <jassisinghbrar@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Vikram Prakash <vikram.prakash@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <ray.jui@...adcom.com>
Subject: Re: [PATCH v3 04/19] mailbox: bcm-flexrm: Use device-managed
 registration API

Looks fine - thanks.

On 2018-12-20 9:19 a.m., Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
>
> Get rid of some boilerplate driver removal code by using the newly added
> device-managed registration API.
>
> Cc: Vikram Prakash <vikram.prakash@...adcom.com>
> Cc: Scott Branden <scott.branden@...adcom.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Ray Jui <ray.jui@...adcom.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>
Acked-by: Scott Branden <scott.branden@...adcom.com>
> ---
>   drivers/mailbox/bcm-flexrm-mailbox.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index d7a8ed7d8097..d713271ebf7c 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1665,7 +1665,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>   		mbox->controller.chans[index].con_priv = &mbox->rings[index];
>   
>   	/* Register mailbox controller */
> -	ret = mbox_controller_register(&mbox->controller);
> +	ret = devm_mbox_controller_register(dev, &mbox->controller);
>   	if (ret)
>   		goto fail_free_debugfs_root;
>   
> @@ -1691,8 +1691,6 @@ static int flexrm_mbox_remove(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	struct flexrm_mbox *mbox = platform_get_drvdata(pdev);
>   
> -	mbox_controller_unregister(&mbox->controller);
> -
>   	debugfs_remove_recursive(mbox->root);
>   
>   	platform_msi_domain_free_irqs(dev);