linux-kernel - Re: [PATCH] lib/rhashtable: Fix work initialization in rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1545328287.185366.501.camel@acm.org>
Date:   Thu, 20 Dec 2018 09:51:27 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     David Miller <davem@...emloft.net>
Cc:     tgraf@...g.ch, herbert@...dor.apana.org.au, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/rhashtable: Fix work initialization in
 rhashtable_init()

On Tue, 2018-12-18 at 21:32 -0800, David Miller wrote:
> From: Bart Van Assche <bvanassche@....org>
> Date: Mon, 17 Dec 2018 13:40:58 -0800
> 
> > The test_insert_dup() function from lib/test_rhashtable.c passes a
> > pointer to a stack object to rhltable_init(). Avoid that the following
> > is reported with object debugging enabled while running the selftest
> > from lib/test_rhashtable.c:
>  ...
> > Signed-off-by: Bart Van Assche <bvanassche@....org>
> 
> Please just fix the test to use the global object created for this purpose
> instead of an unnecessary on-stack instance.

Hi Dave,

I will do that. Thanks for the feedback.

Bart.