linux-kernel - Re: [PATCH kernel v7 20/20] vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87y38jpv03.fsf@concordia.ellerman.id.au>
Date:   Fri, 21 Dec 2018 11:46:04 +1100
From:   Michael Ellerman <michaele@....ibm.com>
To:     Murilo Opsfelder Araujo <muriloo@...ux.ibm.com>,
        Alexey Kardashevskiy <aik@...abs.ru>
Cc:     linuxppc-dev@...ts.ozlabs.org,
        Christoph Hellwig <hch@...radead.org>,
        Jose Ricardo Ziviani <joserz@...ux.ibm.com>,
        kvm@...r.kernel.org, Alistair Popple <alistair@...ple.id.au>,
        Daniel Henrique Barboza <danielhb413@...il.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        kvm-ppc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sam Bobroff <sbobroff@...ux.ibm.com>,
        Piotr Jaroszynski <pjaroszynski@...dia.com>,
        Leonardo Augusto Guimarães Garcia 
        <lagarcia@...ibm.com>, Reza Arbab <arbab@...ux.ibm.com>,
        David Gibson <david@...son.dropbear.id.au>
Subject: Re: [PATCH kernel v7 20/20] vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver

Murilo Opsfelder Araujo <muriloo@...ux.ibm.com> writes:
> On Thu, Dec 20, 2018 at 07:23:50PM +1100, Alexey Kardashevskiy wrote:
...
>> diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h
>> new file mode 100644
>> index 0000000..b80d2d3
>> --- /dev/null
>> +++ b/drivers/vfio/pci/trace.h
...
>> +TRACE_EVENT(vfio_pci_npu2_mmap,
>> +	TP_PROTO(struct pci_dev *pdev, unsigned long hpa, unsigned long ua,
>> +			unsigned long size, int ret),
>> +	TP_ARGS(pdev, hpa, ua, size, ret),
>> +
>> +	TP_STRUCT__entry(
>> +		__field(const char *, name)
>> +		__field(unsigned long, hpa)
>> +		__field(unsigned long, ua)
>> +		__field(unsigned long, size)
>> +		__field(int, ret)
>> +	),
>> +
>> +	TP_fast_assign(
>> +		__entry->name = dev_name(&pdev->dev),
>> +		__entry->hpa = hpa;
>> +		__entry->ua = ua;
>> +		__entry->size = size;
>> +		__entry->ret = ret;
>> +	),
>> +
>> +	TP_printk("%s: %lx -> %lx size=%lx ret=%d", __entry->name, __entry->hpa,
>> +			__entry->ua, __entry->size, __entry->ret)
>> +);
>> +
>> +#endif /* _TRACE_SUBSYS_H */
>
> I think it's too late but this line I guess should read:
>
>   #endif /* _TRACE_VFIO_PCI_H */

Thanks I'll fix it up.

cheers