linux-kernel - Re: [PATCH v2 1/8] mfd: axp20x: name voltage ramping define properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181221083927.GQ4497@dell>
Date:   Fri, 21 Dec 2018 08:39:27 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Priit Laes <plaes@...es.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Olliver Schinagl <oliver@...inagl.nl>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v2 1/8] mfd: axp20x: name voltage ramping define properly

On Tue, 11 Dec 2018, Priit Laes wrote:

> From: Olliver Schinagl <oliver@...inagl.nl>
> 
> The current axp20x names the ramping register 'scal' which probably
> means scaling. Since the register really has nothing to do with
> scaling, but really is the voltage ramp we rename it appropriately.
> 
> Signed-off-by: Olliver Schinagl <oliver@...inagl.nl>
> Signed-off-by: Priit Laes <plaes@...es.org>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> ---
>  include/linux/mfd/axp20x.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I've lost track of what's happening with this set now.

Mark,

Did you take this patch in the end?

> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index 2302b62..a353cd2 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -35,7 +35,7 @@ enum axp20x_variants {
>  #define AXP152_ALDO_OP_MODE		0x13
>  #define AXP152_LDO0_CTRL		0x15
>  #define AXP152_DCDC2_V_OUT		0x23
> -#define AXP152_DCDC2_V_SCAL		0x25
> +#define AXP152_DCDC2_V_RAMP		0x25
>  #define AXP152_DCDC1_V_OUT		0x26
>  #define AXP152_DCDC3_V_OUT		0x27
>  #define AXP152_ALDO12_V_OUT		0x28
> @@ -53,7 +53,7 @@ enum axp20x_variants {
>  #define AXP20X_USB_OTG_STATUS		0x02
>  #define AXP20X_PWR_OUT_CTRL		0x12
>  #define AXP20X_DCDC2_V_OUT		0x23
> -#define AXP20X_DCDC2_LDO3_V_SCAL	0x25
> +#define AXP20X_DCDC2_LDO3_V_RAMP	0x25
>  #define AXP20X_DCDC3_V_OUT		0x27
>  #define AXP20X_LDO24_V_OUT		0x28
>  #define AXP20X_LDO3_V_OUT		0x29

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog