linux-kernel - Re: [PATCH v4 3/8] mfd: stmpe: preparations for STMPE ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181221104250.GM13248@dell>
Date:   Fri, 21 Dec 2018 10:42:50 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Philippe Schenker <dev@...henker.ch>
Cc:     jic23@...nel.org, marcel.ziswiler@...adex.com, stefan@...er.ch,
        thierry.reding@...il.com,
        Max Krummenacher <max.krummenacher@...adex.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-kernel@...r.kernel.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/8] mfd: stmpe: preparations for STMPE ADC driver

On Wed, 12 Dec 2018, Philippe Schenker wrote:

> This prepares the MFD for the STMPE ADC driver. This commit introduces
> devicetree settings that are used by the ADC and adds an init function.
> Common ADC settings that are shared with the touchscreen driver can now
> reside in the overlying MFD.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> Signed-off-by: Max Krummenacher <max.krummenacher@...adex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> ---
> 
> I moved now all enables back to the subdevices. The disable of ADC
> block is now done at remove of mfd. I know this is not particularly
> right, the right way to do this would be with a refcounter.
> 
> But I don't know how to implement this in this driver. If someone does
> not agree to disable adc in remove of mfd, please give me some advice
> in how to do it with refcounter.
> 
> Changes in v4:
>  - New patch: split mfd changes into this precursor patch
>  - Export the added stmpe811_adc_commmon_init function
>  - Disabling adc when mfd is removed
> 
> Changes in v3: None
> Changes in v2:
>  - Move code to setup ADC to MFD device, as it is used by both drivers
>    adc and touchscreen
> 
>  drivers/mfd/Kconfig       |  3 +-
>  drivers/mfd/stmpe.c       | 68 +++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/stmpe.h | 10 ++++++
>  3 files changed, 80 insertions(+), 1 deletion(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog