linux-kernel - Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92c7795c-8d0c-bfb6-e272-27e8441783dd@redhat.com>
Date:   Fri, 21 Dec 2018 12:18:10 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Lendacky <thomas.lendacky@....com>,
        Joerg Roedel <joro@...tes.org>, x86@...nel.org
Subject: Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported

On 21/12/18 11:06, Vitaly Kuznetsov wrote:
>> Btw, I would prefer this without the
>>
>>   default: break;
>>
>> as I don't think we'll ever add something there.
> 
> "640K ought to be enough for anybody" :-)
> 
> But in case you commit it as
> 
> return index != MSR_IA32_MCG_EXT_CTL; 
> 
> I won't object. Thanks,

Radim committed it as it, but I think he did want the switch statement
(hey, vmx_has_emulated_msr has *two* cases!).  It's just the "default:
break;" that is unnecessary or could be "default: return true;".

Paolo