linux-kernel - Re: [PATCH v6 4/7] mtd: spi-nor: add octal read flag for flash mt35xu512aba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Dec 2018 14:45:28 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <yogeshnarayan.gaur@....com>, <linux-mtd@...ts.infradead.org>,
        <boris.brezillon@...tlin.com>, <broonie@...nel.org>,
        <marek.vasut@...il.com>, <vigneshr@...com>,
        <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>
CC:     <robh@...nel.org>, <mark.rutland@....com>, <shawnguo@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <computersforpeace@...il.com>, <frieder.schrempf@...eet.de>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 4/7] mtd: spi-nor: add octal read flag for flash
 mt35xu512aba



On 12/19/2018 12:12 PM, Yogesh Narayan Gaur wrote:
> Add octal read flag for flash mt35xu512aba.
> This flash, mt35xu512aba, is only complaint to SFDP JESD216B and does
> not seem to support newer JESD216C standard that provides auto
> detection of Octal mode capabilities and opcodes. Therefore, this
> capability is manually added using new SPI_NOR_OCTAL_READ flag.
> 
> Signed-off-by: Vignesh R <vigneshr@...com>
> Signed-off-by: Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
> Changes for v6:
> - Correct S-o-b tag with full author name as 'Yogesh Narayan Gaur'.
> Changes for v5:
> - Modified string 'octo' with 'octal'.
> Changes for v4:
> - None
> Changes for v3:
> - Modified string 'octal' with 'octo'.
> Changes for v2:
> - Incorporated review comments of Boris and Vignesh
> 
>  drivers/mtd/spi-nor/spi-nor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 872d707..53a3bcc 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1877,7 +1877,8 @@ static const struct flash_info spi_nor_ids[] = {
>  	/* Micron */
>  	{
>  		"mt35xu512aba", INFO(0x2c5b1a, 0, 128 * 1024, 512,
> -			SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES)
> +			SECT_4K | USE_FSR | SPI_NOR_OCTAL_READ |
> +			SPI_NOR_4B_OPCODES)
>  	},
>  
>  	/* PMC */
>