linux-kernel - Re: [PATCH] mfd: mc13xxx: fix a missing check of a register-read failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181221145210.GT13248@dell>
Date:   Fri, 21 Dec 2018 14:52:10 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: mc13xxx: fix a missing check of a register-read
 failure

On Thu, 20 Dec 2018, Kangjie Lu wrote:

> When mc13xxx_reg_read() fails, "old_adc0" is uninitialized and will
> contain random value. Further execution uses "old_adc0" even when
> mc13xxx_reg_read() fails.
> The fix checks the return value of mc13xxx_reg_read(), and exits
> the execution when it fails.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>  drivers/mfd/mc13xxx-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog