linux-kernel - Re: [PATCH] smack: Fix a memory leak in smack_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181221163654.GY2217@ZenIV.linux.org.uk>
Date:   Fri, 21 Dec 2018 16:36:54 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Casey Schaufler <casey@...aufler-ca.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] smack: Fix a memory leak in smack_add_opt()

On Fri, Dec 21, 2018 at 12:09:58PM +0300, Dan Carpenter wrote:
> The function is leaking "opts" on the error paths.
> 
> Fixes: 90e3b564ab93 ("smack: take the guts of smack_parse_opts_str() into a new helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

D'oh...  Applied, thanks for spotting that braino.