linux-kernel - Re: [PATCH v5 6/8] iio: adc: add STMPE ADC devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Dec 2018 12:25:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     Philippe Schenker <dev@...henker.ch>
Cc:     jic23@...nel.org, marcel.ziswiler@...adex.com, stefan@...er.ch,
        robh@...nel.org, alexandre.torgue@...com, shawnguo@...nel.org,
        dmitry.torokhov@...il.com, thierry.reding@...il.com,
        digetx@...il.com, lee.jones@...aro.org, coquelin.stm32@...il.com,
        Max Krummenacher <max.krummenacher@...adex.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
        Hartmut Knaack <knaack.h@....de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v5 6/8] iio: adc: add STMPE ADC devicetree bindings

On Fri, 21 Dec 2018 14:46:35 +0100, Philippe Schenker wrote:
> From: Stefan Agner <stefan@...er.ch>
> 
> This adds the devicetree bindings for the STMPE ADC. This also corrects
> a typo in st,sample-time it is rather "6 -> 124 clocks" according
> to the datasheet and not 144.
> We need to use the naming stmpe_adc in devicetree because this is given
> by the mfd device.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> Signed-off-by: Max Krummenacher <max.krummenacher@...adex.com>
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> ---
> 
> Changes in v5:
>  - Made a one column list
>  - Cleared note about precedence
>  - Changed example to a full STMPE811 device with MFD, touchscreen, and the new
>    stmpe_adc driver.
>  - Added Jonathan Cameron's Reviewed-by
> 
> Changes in v4:
>  - Put reformatting in a separate precursor patch.
> 
> Changes in v3:
>  - Reformatted documentation for touchscreen to use tabs and have a better
>    overview of the settings.
>  - Added note which adc-settings will take precedence.
>  - changed typo in sample-time setting from 144 clocks to 124 clocks, as stated
>    in the datasheet.
> 
> Changes in v2:
>  - Moved the bindings for ADC to the overlying mfd.
>  - Reformatted for better readability
> 
>  .../devicetree/bindings/iio/adc/stmpe-adc.txt | 21 +++++
>  .../bindings/input/touchscreen/stmpe.txt      | 88 +++++++++++++------
>  .../devicetree/bindings/mfd/stmpe.txt         | 14 +++
>  3 files changed, 98 insertions(+), 25 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/stmpe-adc.txt
> 

Reviewed-by: Rob Herring <robh@...nel.org>