linux-kernel - Re: [PATCH 09/21] PCI: imx6: Drop imx6_pcie_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1545418520.22930.82.camel@impinj.com>
Date:   Fri, 21 Dec 2018 18:55:21 +0000
From:   Trent Piepho <tpiepho@...inj.com>
To:     "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC:     "hongxing.zhu@....com" <hongxing.zhu@....com>,
        "aisheng.dong@....com" <aisheng.dong@....com>,
        "cphealy@...il.com" <cphealy@...il.com>,
        "linux-imx@....com" <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "fabio.estevam@....com" <fabio.estevam@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "leonard.crestez@....com" <leonard.crestez@....com>
Subject: Re: [PATCH 09/21] PCI: imx6: Drop imx6_pcie_link_up()

On Thu, 2018-12-20 at 23:27 -0800, Andrey Smirnov wrote:
> Until commit 4d107d3b5a68 ("PCI: imx6: Move link up check into
> imx6_pcie_wait_for_link()") the driver relied on both LINK_UP and
> LINK_IN_TRAINING to determine if PCIE link was up.

I've already got a patch in that fixed this issue.  Queued for 4.19 and
4.14 stable.

The problem was created by 886bc5ceb5cc in one branch and by
4d107d3b5a68 on another branch, that when merged in 562df5c8521e, the
merge kept some pieces from each commit and dropped other pieces, which
resulted in this check getting dropped.