linux-kernel - Re: [PATCH] serial/sunsu: fix refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181221.112521.1449281052807365475.davem@davemloft.net>
Date:   Fri, 21 Dec 2018 11:25:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tiny.windzz@...il.com
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        sparclinux@...r.kernel.org, daniel.lezcano@...aro.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial/sunsu: fix refcount leak

From: Yangtao Li <tiny.windzz@...il.com>
Date: Wed, 12 Dec 2018 11:01:45 -0500

> The function of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> 
> su_get_type() doesn't do that. The match node are used as an identifier
> to compare against the current node, so we can directly drop the refcount
> after getting the node from the path as it is not used as pointer.
> 
> Fix this by use a single variable and drop the refcount right after
> of_find_node_by_path().
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Applied.