linux-kernel - Re: [PATCH v2 1/2] soc: qcom: rmtfs-mem: Add class to enable uevents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Dec 2018 14:05:33 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Evan Green <evgreen@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Brian Norris <briannorris@...omium.org>,
        Ben Chan <benchan@...omium.org>, linux-arm-msm@...r.kernel.org,
        David Brown <david.brown@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] soc: qcom: rmtfs-mem: Add class to enable uevents

On Fri 21 Dec 12:10 PST 2018, Evan Green wrote:

> Currently the qcom_rmtfs_memN devices are entirely invisible to the udev world.
> Add a class to the rmtfs device so that uevents fire when the device is added.
> 
> Signed-off-by: Evan Green <evgreen@...omium.org>

I agree with Brian on the whitespace chances, apart from that you have
my

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
> 
> Changes in v2:
> - Moved class registration/deregistration into init/exit routines (Brian)
> 
>  drivers/soc/qcom/rmtfs_mem.c | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index 97bb5989aa211..99a1363ece254 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -132,6 +132,11 @@ static int qcom_rmtfs_mem_release(struct inode *inode, struct file *filp)
>  	return 0;
>  }
>  
> +static struct class rmtfs_class = {
> +	.owner          = THIS_MODULE,
> +	.name           = "rmtfs",
> +};
> +
>  static const struct file_operations qcom_rmtfs_mem_fops = {
>  	.owner = THIS_MODULE,
>  	.open = qcom_rmtfs_mem_open,
> @@ -199,8 +204,8 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>  
>  	dev_set_name(&rmtfs_mem->dev, "qcom_rmtfs_mem%d", client_id);
>  	rmtfs_mem->dev.id = client_id;
> +	rmtfs_mem->dev.class = &rmtfs_class;
>  	rmtfs_mem->dev.devt = MKDEV(MAJOR(qcom_rmtfs_mem_major), client_id);
> -
>  	ret = cdev_device_add(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to add cdev: %d\n", ret);
> @@ -239,7 +244,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>  	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  put_device:
>  	put_device(&rmtfs_mem->dev);
> -
>  	return ret;
>  }
>  
> @@ -258,7 +262,6 @@ static int qcom_rmtfs_mem_remove(struct platform_device *pdev)
>  
>  	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  	put_device(&rmtfs_mem->dev);
> -
>  	return 0;
>  }
>  
> @@ -277,32 +280,42 @@ static struct platform_driver qcom_rmtfs_mem_driver = {
>  	},
>  };
>  
> -static int qcom_rmtfs_mem_init(void)
> +static int __init qcom_rmtfs_mem_init(void)
>  {
>  	int ret;
>  
> +	ret = class_register(&rmtfs_class);
> +	if (ret)
> +		return ret;
> +
>  	ret = alloc_chrdev_region(&qcom_rmtfs_mem_major, 0,
>  				  QCOM_RMTFS_MEM_DEV_MAX, "qcom_rmtfs_mem");
>  	if (ret < 0) {
>  		pr_err("qcom_rmtfs_mem: failed to allocate char dev region\n");
> -		return ret;
> +		goto unregister_class;
>  	}
>  
>  	ret = platform_driver_register(&qcom_rmtfs_mem_driver);
>  	if (ret < 0) {
>  		pr_err("qcom_rmtfs_mem: failed to register rmtfs_mem driver\n");
> -		unregister_chrdev_region(qcom_rmtfs_mem_major,
> -					 QCOM_RMTFS_MEM_DEV_MAX);
> +		goto unregister_chrdev;
>  	}
>  
> +	return 0;
> +
> +unregister_chrdev:
> +	unregister_chrdev_region(qcom_rmtfs_mem_major, QCOM_RMTFS_MEM_DEV_MAX);
> +unregister_class:
> +	class_unregister(&rmtfs_class);
>  	return ret;
>  }
>  module_init(qcom_rmtfs_mem_init);
>  
> -static void qcom_rmtfs_mem_exit(void)
> +static void __exit qcom_rmtfs_mem_exit(void)
>  {
>  	platform_driver_unregister(&qcom_rmtfs_mem_driver);
>  	unregister_chrdev_region(qcom_rmtfs_mem_major, QCOM_RMTFS_MEM_DEV_MAX);
> +	class_unregister(&rmtfs_class);
>  }
>  module_exit(qcom_rmtfs_mem_exit);
>  
> -- 
> 2.18.1
>