linux-kernel - [PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181221042719.29954-1-f.fainelli@gmail.com>
Date:   Thu, 20 Dec 2018 20:27:16 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     linux-vger@...nel.org
Cc:     linux-serial@...r.kernel.org, mpe@...erman.id.au, arnd@...db.de,
        gregkh@...uxfoundation.org, linux@...ck-us.net,
        benh@...nel.crashing.org, paulus@...ba.org,
        linuxppc-dev@...ts.ozlabs.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Jiri Slaby <jslaby@...e.com>, Nishanth Menon <nm@...com>,
        Tony Lindgren <tony@...mide.com>, Vignesh R <vigneshr@...com>,
        Lokesh Vutla <lokeshvutla@...com>,
        Michael Moese <mmoese@...e.de>,
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250"

This reverts commit 6d11023c345e369bcb9d5a68b271764e362c1f6e ("serial:
8250: Default SERIAL_OF_PLATFORM to SERIAL_8250") since that breaks at
least mpc8544ds (PowerPC) using arch/powerpc/kernel/legacy_serial.c.

See https://lkml.org/lkml/2018/12/5/1491 for discussion and analysis

Fixes: 6d11023c345e ("serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250")
Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
---
 drivers/tty/serial/8250/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index d7737dca0e48..15c2c5463835 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -484,7 +484,6 @@ config SERIAL_8250_PXA
 config SERIAL_OF_PLATFORM
 	tristate "Devicetree based probing for 8250 ports"
 	depends on SERIAL_8250 && OF
-	default SERIAL_8250
 	help
 	  This option is used for all 8250 compatible serial ports that
 	  are probed through devicetree, including Open Firmware based
-- 
2.19.1