linux-kernel - Re: [PATCH] bcache: fix indentation issue, remove tabs on a hunk of code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d3bdea3-d155-b116-f09f-ad5a0b00718a@suse.de>
Date:   Sat, 22 Dec 2018 21:03:43 +0800
From:   Coly Li <colyli@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: fix indentation issue, remove tabs on a hunk of
 code

On 12/22/18 7:18 上午, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a hunk of code that is indented one level too deep, fix this
> by removing the extra tabs.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Hi Colin,

Nice catch, thank you! I will add it into my for-next directory.

Coly Li

> ---
>  drivers/md/bcache/super.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 4dee119c3664..a697a3a923cd 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1615,21 +1615,21 @@ static void conditional_stop_bcache_device(struct cache_set *c,
>  		 */
>  		pr_warn("stop_when_cache_set_failed of %s is \"auto\" and cache is dirty, stop it to avoid potential data corruption.",
>  			d->disk->disk_name);
> -			/*
> -			 * There might be a small time gap that cache set is
> -			 * released but bcache device is not. Inside this time
> -			 * gap, regular I/O requests will directly go into
> -			 * backing device as no cache set attached to. This
> -			 * behavior may also introduce potential inconsistence
> -			 * data in writeback mode while cache is dirty.
> -			 * Therefore before calling bcache_device_stop() due
> -			 * to a broken cache device, dc->io_disable should be
> -			 * explicitly set to true.
> -			 */
> -			dc->io_disable = true;
> -			/* make others know io_disable is true earlier */
> -			smp_mb();
> -			bcache_device_stop(d);
> +		/*
> +		 * There might be a small time gap that cache set is
> +		 * released but bcache device is not. Inside this time
> +		 * gap, regular I/O requests will directly go into
> +		 * backing device as no cache set attached to. This
> +		 * behavior may also introduce potential inconsistence
> +		 * data in writeback mode while cache is dirty.
> +		 * Therefore before calling bcache_device_stop() due
> +		 * to a broken cache device, dc->io_disable should be
> +		 * explicitly set to true.
> +		 */
> +		dc->io_disable = true;
> +		/* make others know io_disable is true earlier */
> +		smp_mb();
> +		bcache_device_stop(d);
>  	} else {
>  		/*
>  		 * dc->stop_when_cache_set_failed == BCH_CACHED_STOP_AUTO
>