linux-kernel - Re: [PATCH v2 1/6] staging: iio: adc: ad7606: Simplify the Kconfing menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181222174026.63bb6d02@archlinux>
Date:   Sat, 22 Dec 2018 17:40:26 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <Michael.Hennerich@...log.com>, <knaack.h@....de>,
        <lars@...afoo.de>, <pmeerw@...erw.net>,
        <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCH v2 1/6] staging: iio: adc: ad7606: Simplify the Kconfing
 menu

On Mon, 17 Dec 2018 14:23:35 +0200
Stefan Popa <stefan.popa@...log.com> wrote:

> There is no point in having three menu entries that can be selected
> individually. Instead, the SPI and parallel interfaces should select
> AD7606.
> 
> Signed-off-by: Stefan Popa <stefan.popa@...log.com>
I think this looks right, but I've gotten these wrong too many times
to remember so fingers crossed.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.  Particularly useful with these
sorts of patches!

Thanks,

Jonathan

> ---
>  drivers/staging/iio/adc/Kconfig | 27 ++++++++++-----------------
>  1 file changed, 10 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index fc23059..302639a 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -4,35 +4,28 @@
>  menu "Analog to digital converters"
>  
>  config AD7606
> -	tristate "Analog Devices AD7606 ADC driver"
> -	depends on GPIOLIB || COMPILE_TEST
> -	depends on HAS_IOMEM
> +	tristate
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
> -	help
> -	  Say yes here to build support for Analog Devices:
> -	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
> -
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called ad7606.
>  
>  config AD7606_IFACE_PARALLEL
> -	tristate "parallel interface support"
> -	depends on AD7606
> +	tristate "Analog Devices AD7606 ADC driver with parallel interface support"
> +	depends on HAS_IOMEM
> +	select AD7606
>  	help
> -	  Say yes here to include parallel interface support on the AD7606
> -	  ADC driver.
> +	  Say yes here to build parallel interface support for Analog Devices:
> +	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
>  
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ad7606_parallel.
>  
>  config AD7606_IFACE_SPI
> -	tristate "spi interface support"
> -	depends on AD7606
> +	tristate "Analog Devices AD7606 ADC driver with spi interface support"
>  	depends on SPI
> +	select AD7606
>  	help
> -	  Say yes here to include parallel interface support on the AD7606
> -	  ADC driver.
> +	  Say yes here to build spi interface support for Analog Devices:
> +	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
>  
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called ad7606_spi.