linux-kernel - Re: [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181224121417.GB2070@rapoport-lnx>
Date:   Mon, 24 Dec 2018 14:14:18 +0200
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     "huang.zijiang" <huang.zijiang@....com.cn>
Cc:     akpm@...ux-foundation.org, rppt@...ux.vnet.ibm.com,
        mhocko@...e.com, sfr@...b.auug.org.au, mpe@...erman.id.au,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        wang.yi59@....com.cn
Subject: Re: [PATCH] firmware/memmap:Modify memblock_alloc to
 memblock_alloc_nopanic

On Mon, Dec 24, 2018 at 04:41:22PM +0800, huang.zijiang wrote:
> From: "huang.zijiang" <huang.zijiang@....com.cn>
> 
> memblock_alloc never returns NULL because panic never returns
> 
> Signed-off-by: huang.zijiang <huang.zijiang@....com.cn>

Acked-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  drivers/firmware/memmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
> index d168c87..ec4fd25 100644
> --- a/drivers/firmware/memmap.c
> +++ b/drivers/firmware/memmap.c
> @@ -333,7 +333,7 @@ int __init firmware_map_add_early(u64 start, u64 end, const char *type)
>  {
>  	struct firmware_map_entry *entry;
> 
> -	entry = memblock_alloc(sizeof(struct firmware_map_entry),
> +	entry = memblock_alloc_nopanic(sizeof(struct firmware_map_entry),
>  			       SMP_CACHE_BYTES);
>  	if (WARN_ON(!entry))
>  		return -ENOMEM;
> -- 
> 1.8.3.1
> 

-- 
Sincerely yours,
Mike.