linux-kernel - Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a78261cba6647cd9665ed42f175eeedf412b85b.camel@gmail.com>
Date:   Mon, 24 Dec 2018 20:16:38 +0500
From:   Ivan Mironov <mironov.ivan@...il.com>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Ariel Elior <ariel.elior@...ium.com>,
        Sudarsana Kalluru <sudarsana.kalluru@...ium.com>,
        "everest-linux-l2@...ium.com" <everest-linux-l2@...ium.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in
 bnx2x_del_all_vlans() on some hw

On Mon, 2018-12-24 at 14:26 +0000, Sudarsana Reddy Kalluru wrote:
> Thanks a lot for root-causing the issue and the patch.
> Another (simpler) way to address this would be to invoke bnx2x_del_all_vlans() only for the newer chips, e.g., 
> +       if (!CHIP_IS_E1(bp)) {
> 	/* Remove all currently configured VLANs */
>                rc = bnx2x_del_all_vlans(bp);
>                if (rc < 0)
>                        BNX2X_ERR("Failed to delete all VLANs\n");
> +       }
> Could you please check on this?

Done. See the PATCH v2 in the mailing list. I tested it on my system.