linux-kernel - Re: [PATCH] drivers/net: appletalk/cops: remove redundant if statement and mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c43fd16-8c73-00b8-7c72-1f3e15a2fdc2@canonical.com>
Date:   Mon, 24 Dec 2018 18:11:27 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/net: appletalk/cops: remove redundant if
 statement and mask

On 24/12/2018 18:08, David Miller wrote:
> From: Colin King <colin.king@...onical.com>
> Date: Sat, 22 Dec 2018 16:58:41 +0000
> 
>> @@ -777,10 +777,7 @@ static void cops_rx(struct net_device *dev)
>>          }
>>  
>>          /* Get response length. */
>> -	if(lp->board==DAYNA)
>> -        	pkt_len = inb(ioaddr) & 0xFF;
>> -	else
>> -		pkt_len = inb(ioaddr) & 0x00FF;
>> +	pkt_len = inb(ioaddr);
> 
> There are other instances of similar weird identical statements guarded
> by the test on the board type being DAYNA.
> 
> For example, in cops_send_packet():
> 
> 	if(lp->board == DAYNA)
>                	outb(skb->len >> 8, ioaddr);
> 	else
> 		outb((skb->len >> 8)&0x0FF, ioaddr);
> 
> Could you scan the rest of the driver and deal with all of these
> instances in one go?

Will do, probably in a day or so.
> 
> Thank you!
>