linux-kernel - RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR18MB21349BAF4AF8E373EE037969D8BB0@DM5PR18MB2134.namprd18.prod.outlook.com>
Date:   Mon, 24 Dec 2018 08:49:49 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "QLogic-Storage-Upstream@...gic.com" 
        <QLogic-Storage-Upstream@...gic.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
 qla4xxx_copy_from_fwddb_param


> -----Original Message-----
> From: YueHaibing <yuehaibing@...wei.com>
> Sent: Thursday, December 20, 2018 8:46 AM
> To: QLogic-Storage-Upstream@...gic.com; jejb@...ux.ibm.com;
> martin.petersen@...cle.com
> Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; YueHaibing
> <yuehaibing@...wei.com>
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
> 
> External Email
> 
> ----------------------------------------------------------------------
> External Email
> 
> The return code should be check while qla4xxx_copy_from_fwddb_param fails.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
> 
>         rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
>                                            fw_ddb_entry);
> +       if (rc)
> +               goto free_sess;
> 
>         ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
>                    __func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
> 

Thanks
Acked-by: Manish Rangankar <mrangankar@...vell.com>