linux-kernel - Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Dec 2018 09:01:26 +0000
From:   Nilesh Javali <njavali@...vell.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "Dept-Eng QLogic Storage Upstream" 
        <QLogic-Storage-Upstream@...ium.com>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch
 fall-through


On 11/28/18, 10:03 AM, "linux-scsi-owner@...r.kernel.org on behalf of
Gustavo A. R. Silva" <linux-scsi-owner@...r.kernel.org on behalf of
gustavo@...eddedor.com> wrote:

>External Email
>
>In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>where we are expecting to fall through.
>
>Notice that, in this particular case, I replaced "allow fall-through"
>with a "fall through" annotation, which is what GCC is expecting to
>find.
>
>Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>---
> drivers/scsi/qla4xxx/ql4_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
>index 1c702cd22359..7fd3491ea2d9 100644
>--- a/drivers/scsi/qla4xxx/ql4_os.c
>+++ b/drivers/scsi/qla4xxx/ql4_os.c
>@@ -2876,7 +2876,7 @@ static int qla4xxx_session_get_param(struct
>iscsi_cls_session *cls_sess,
>                                                chap_tbl.secret_len);
>                        }
>                }
>-               /* allow fall-through */
>+               /* fall through */
>        default:
>                return iscsi_session_get_param(cls_sess, param, buf);
>        }
>--
>2.17.1

Thanks.
Acked-by: Nilesh Javali <njavali@...vell.com>