linux-kernel - [PATCH v2] gpu: anx7808: fix a missing check in anx78xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20181225050234.66210-1-kjlu@umn.edu>
Date:   Mon, 24 Dec 2018 23:02:34 -0600
From:   Kangjie Lu <kjlu@....edu>
To:     kjlu@....edu
Cc:     pakki001@....edu, Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] gpu: anx7808: fix a missing check in anx78xx_poweron

Both anx78xx_set_bits() and anx78xx_clear_bits() in the poweron process
may fail. The fix inserts checks for their return values.

Signed-off-by: Kangjie Lu <kjlu@....edu>
---
 drivers/gpu/drm/bridge/analogix-anx78xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c
index 3b0fe2b188db..4f35aced65a0 100644
--- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
@@ -646,6 +646,7 @@ static void anx78xx_poweron(struct anx78xx *anx78xx)
 				err);
 		return;
 	}
+
 	err = anx78xx_clear_bits(anx78xx->map[I2C_IDX_TX_P2],
 			SP_POWERDOWN_CTRL_REG,
 			SP_REGISTER_PD | SP_TOTAL_PD);
-- 
2.17.2 (Apple Git-113)