linux-kernel - Re: [PATCH RESEND v8 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <081f7986-0f8e-bd42-bae2-17058c7da301@amlogic.com>
Date:   Tue, 25 Dec 2018 15:55:16 +0800
From:   Liang Yang <liang.yang@...ogic.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>
CC:     Boris Brezillon <boris.brezillon@...tlin.com>,
        <linux-mtd@...ts.infradead.org>, Yixun Lan <yixun.lan@...ogic.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Jerome Brunet <jbrunet@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        Rob Herring <robh@...nel.org>, Jian Hu <jian.hu@...ogic.com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        Victor Wan <victor.wan@...ogic.com>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND v8 2/2] mtd: rawnand: meson: add support for
 Amlogic NAND flash controller

Hi Martin,
On 2018/12/23 1:07, Martin Blumenstingl wrote:
> Hi Jianxin, Hi Liang,
> 
> On Fri, Dec 21, 2018 at 12:45 PM Jianxin Pan <jianxin.pan@...ogic.com> wrote:
>>
>> From: Liang Yang <liang.yang@...ogic.com>
>>
>> Add initial support for the Amlogic NAND flash controller which found
>> in the Meson-GXBB/GXL/AXG SoCs.
>>
>> Signed-off-by: Liang Yang <liang.yang@...ogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@...ogic.com>
>> Signed-off-by: Jianxin Pan <jianxin.pan@...ogic.com>
>> ---
>>   drivers/mtd/nand/raw/Kconfig      |   10 +
>>   drivers/mtd/nand/raw/Makefile     |    1 +
>>   drivers/mtd/nand/raw/meson_nand.c | 1468 +++++++++++++++++++++++++++++++++++++
>>   3 files changed, 1479 insertions(+)
>>   create mode 100644 drivers/mtd/nand/raw/meson_nand.c
>>
>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
>> index 1a55d3e..d05ff20 100644
>> --- a/drivers/mtd/nand/raw/Kconfig
>> +++ b/drivers/mtd/nand/raw/Kconfig
>> @@ -541,4 +541,14 @@ config MTD_NAND_TEGRA
>>            is supported. Extra OOB bytes when using HW ECC are currently
>>            not supported.
>>
>> +config MTD_NAND_MESON
>> +       tristate "Support for NAND controller on Amlogic's Meson SoCs"
>> +       depends on ARCH_MESON || COMPILE_TEST
>> +       depends on COMMON_CLK_AMLOGIC
>> +       select COMMON_CLK_REGMAP_MESON
> I believe that "depends on COMMON_CLK_AMLOGIC" and "select
> COMMON_CLK_REGMAP_MESON" are not necessary:
> the driver should build fine without them because it's only
> interfacing with the common clock framework.
> the common clock framework is enabled by ARCH_MESON and for the
> COMPILE_TEST case the common clock framework provides stub
> implementations inside the headers.
> 
>> +       select MFD_SYSCON
>> +       help
>> +         Enables support for NAND controller on Amlogic's Meson SoCs.
>> +         This controller is found on Meson GXBB, GXL, AXG SoCs.
> you are explicitly mentioning GXBB here but you don't add a "GXBB" compatible.
> I suggest to shorten this sentence ("This controller is found on Meson
> SoCs.") because this driver can also support the 32-bit
> Meson8/Meson8b/Meson8m2 SoCs with minor adjustments.
> 
we only have tested on Meson GXL and AXG platform, but it should support 
GXBB and Meson8/Meson8b/Meson8m2 and the differences between these 
controllers are only the base address of register and some SD_EMMC_CLOCK 
control bits.

i think "This controller is found on Meson SoCs." is ok.

> Regards
> Martin
> 
> .
>