linux-kernel - Re: [PATCH] fs: proc: check status of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181226065850.GG2217@ZenIV.linux.org.uk>
Date:   Wed, 26 Dec 2018 06:58:50 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Kangjie Lu <kjlu@....edu>, pakki001@....edu,
        Andrew Morton <akpm@...ux-foundation.org>,
        Davidlohr Bueso <dbueso@...e.de>,
        David Howells <dhowells@...hat.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: proc: check status of register_filesystem

On Wed, Dec 26, 2018 at 09:18:56AM +0300, Alexey Dobriyan wrote:
> On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote:
> > register_filesystem() could fail. The fix issues an error message if it
> > fails.
> 
> > -	register_filesystem(&proc_fs_type);
> > +	if (register_filesystem(&proc_fs_type))
> > +		pr_err("failed to register the filesystem.\n");
> 
> No, register_filesystem() should do it.

Folks, check when would it fail.  If we have something called "proc"
already registered by the time when proc_root_init() runs... might
as well have been a panic().