linux-kernel - Re: [PATCH] drm/bridge/panel: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1891132.39bZHgSTRL@avalon>
Date:   Wed, 26 Dec 2018 11:40:23 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Brajeswar Ghosh <brajeswar.linux@...il.com>
Cc:     architt@...eaurora.org, a.hajda@...sung.com, airlied@...ux.ie,
        jrdr.linux@...il.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, sabyasachi.linux@...il.com
Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

Hi Brajeswar,

Thank you for the patch.

On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> Remove drm/drm_panel.h which is included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>
> ---
>  drivers/gpu/drm/bridge/panel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba213ef6..402b318eeeb2 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
>  #include <drm/drm_crtc_helper.h>
>  #include <drm/drm_encoder.h>
>  #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>

While at it, how about sorting headers alphabetically to make sure this won't 
happen again ?

With that change,

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  struct panel_bridge {
>  	struct drm_bridge bridge;

-- 
Regards,

Laurent Pinchart