linux-kernel - Re: [PATCH] clk: dove: fix refcount leak in dove_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lg4c9tnp.fsf@bootlin.com>
Date:   Wed, 26 Dec 2018 16:47:38 +0100
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Yangtao Li <tiny.windzz@...il.com>
Cc:     mturquette@...libre.com, sboyd@...nel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: dove: fix refcount leak in dove_clk_init()

Hi Yangtao,
 
 On mer., déc. 26 2018, Yangtao Li <tiny.windzz@...il.com> wrote:

> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.

Reviewed-by: Gregory CLEMENT <gregory.clement@...tlin.com>

Thanks,

Gregory

>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/clk/mvebu/dove.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/mvebu/dove.c b/drivers/clk/mvebu/dove.c
> index e0dd99f36bf4..0bd09d33f9cf 100644
> --- a/drivers/clk/mvebu/dove.c
> +++ b/drivers/clk/mvebu/dove.c
> @@ -188,10 +188,14 @@ static void __init dove_clk_init(struct device_node *np)
>  
>  	mvebu_coreclk_setup(np, &dove_coreclks);
>  
> -	if (ddnp)
> +	if (ddnp) {
>  		dove_divider_clk_init(ddnp);
> +		of_node_put(ddnp);
> +	}
>  
> -	if (cgnp)
> +	if (cgnp) {
>  		mvebu_clk_gating_setup(cgnp, dove_gating_desc);
> +		of_node_put(cgnp);
> +	}
>  }
>  CLK_OF_DECLARE(dove_clk, "marvell,dove-core-clock", dove_clk_init);
> -- 
> 2.17.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com