linux-kernel - [PATCH] firmware: qcom: scm: add error include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 27 Dec 2018 23:55:27 +0100
From:   Stefan Agner <stefan@...er.ch>
To:     bjorn.andersson@...aro.org, robdclark@...il.com
Cc:     jonathan@...ek.ca, linux-kernel@...r.kernel.org,
        Stefan Agner <stefan@...er.ch>
Subject: [PATCH] firmware: qcom: scm: add error include

In some configurations the preprocessor define ENODEV is missing
leading to compile time errors (e.g. when using imx_v6_v7_defconfig).

Signed-off-by: Stefan Agner <stefan@...er.ch>
---
I noticed while compiling todays master branch with imx_v6_v7_defconfig:

In file included from drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:
./include/linux/qcom_scm.h:73:10: error: use of undeclared identifier 'ENODEV'
        return -ENODEV;
                ^

I think this only got uncovered due to e6f6d63ed14c ("drm/msm: add headless
gpu device for imx5") but it seems to be a missing include already before that
commit.

--
Stefan


 include/linux/qcom_scm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
index 06996ad4f2bc..ce5a476fd733 100644
--- a/include/linux/qcom_scm.h
+++ b/include/linux/qcom_scm.h
@@ -13,6 +13,7 @@
 #ifndef __QCOM_SCM_H
 #define __QCOM_SCM_H
 
+#include <linux/err.h>
 #include <linux/types.h>
 #include <linux/cpumask.h>
 
-- 
2.20.1