linux-kernel - Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ff6a55912a5b4f9462484d90bab3084@codeaurora.org>
Date:   Fri, 28 Dec 2018 13:19:02 +0530
From:   Balakrishna Godavarthi <bgodavar@...eaurora.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     marcel@...tmann.org, johan.hedberg@...il.com,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        hemantg@...eaurora.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors
 for wcn3990

Hi Matthias,

On 2018-12-28 01:55, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote:
>> During initalization of wcn3990, we observed UART is reading some
>> stray bytes on the Rx line. This is logging Frame reassembly errors
>> on the serial console. This could be because of tristate of Tx line
>> of wcn3990 during boot up.
> 
> My testing suggests that this change is not needed if the Rx line of
> the SoC/AP is configured with a pull-up. We'd probably all prefer not
> to have this change if there's a neater way to address the garbage
> data. Could you test with adding the pull-up and dropping this patch
> on your side?
> 
> Thanks
> 
> Matthias

Thanks a lot it worked to me. will drop this patch.

-- 
Regards
Balakrishna.