linux-kernel - Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181228084834.GA8658@lst.de>
Date:   Fri, 28 Dec 2018 09:48:34 +0100
From:   Christoph Hellwig <hch@....de>
To:     Huang Shijie <sjhuang@...vatar.ai>
Cc:     akpm@...ux-foundation.org, linux@...linux.org.uk, arnd@...db.de,
        gregkh@...uxfoundation.org, hch@....de, m.szyprowski@...sung.com,
        robin.murphy@....com, sfr@...b.auug.org.au,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux-foundation.org, shijie8@...il.com
Subject: Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to
 gen_pool_has_addr

On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote:
> Follow the kernel conventions, rename addr_in_gen_pool to
> gen_pool_has_addr.

Which convention?  The old name certainly looks more sensible to me.

If we really want to change anything about this function I'd suggest
to drop the size argument, as the address itself should describe the
region good enough.