linux-kernel - Re: [PATCH] ipv6/route: Add a missing check on proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181227.161825.582087596488298445.davem@davemloft.net>
Date:   Thu, 27 Dec 2018 16:18:25 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pakki001@....edu
Cc:     kjlu@....edu, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6/route: Add a missing check on proc_dointvec

From: Aditya Pakki <pakki001@....edu>
Date: Mon, 24 Dec 2018 10:30:17 -0600

> While flushing the cache via  ipv6_sysctl_rtcache_flush(), the call
> to proc_dointvec() may fail. The fix adds a check that returns the
> error, on failure.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>

Applied, but honestly running garbage collection even if the value
isn't change is completely harmless.