linux-kernel - Re: [GIT PULL] sound updates for 4.21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjXVPpDWHzvNL=9gGVGNnYg1jOH8hQx=dq4caEzip-n0g@mail.gmail.com>
Date:   Fri, 28 Dec 2018 11:04:48 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] sound updates for 4.21

On Fri, Dec 28, 2018 at 9:07 AM Takashi Iwai <tiwai@...e.de> wrote:
>
> 1) Whether ASoC driver cannot work with these Dell machines at all

I'm willing to test patches.

Right now, the reason it fails to even load is that "codec_mask" is 0x0001.

And the skl_hda_dsp_generic.c code requires

        // This will be 1 for 0x0001
        codec_count = hweight_long(codec_mask);

        if (codec_count == 1 && codec_mask & IDISP_CODEC_MASK) {
           .. this is ok ..
        } else if (codec_count == 2 && codec_mask & IDISP_CODEC_MASK) {
           .. as is this ..
        } else {
           .. but here we return -EINVAL;
        }

and that basically requires that IDISP_CODEC_MASK be part of
codec_mask. Which it isn't (IDISP_CODEC_MASK is 0x4).

Anyway, as long as the ASoC driver refuses to touch this, the default
pretty much *has* to be the legacy PCI driver.

                Linus