linux-kernel - Re: [PATCH] clk: ti: fix refcount leak in ti_dt_clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <154602523753.179992.582803383819271608@swboyd.mtv.corp.google.com>
Date:   Fri, 28 Dec 2018 11:27:17 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Yangtao Li <tiny.windzz@...il.com>, mturquette@...libre.com,
        t-kristo@...com
Cc:     linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yangtao Li <tiny.windzz@...il.com>
Subject: Re: [PATCH] clk: ti: fix refcount leak in ti_dt_clocks_register()

Quoting Yangtao Li (2018-12-26 05:21:31)
> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/clk/ti/clk.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Applied to clk-next and fixed a whine

drivers/clk/ti/clk.c:197: trailing whitespace, space before tab in indent.

please be more careful next time. Also, please add fixes tags to fixes.