linux-kernel - Re: KASAN: use-after-free Read in filemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181228235106.okk3oastsnpxusxs@kshutemo-mobl1>
Date:   Sat, 29 Dec 2018 02:51:06 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     syzbot <syzbot+b437b5a429d680cf2217@...kaller.appspotmail.com>,
        darrick.wong@...cle.com, hannes@...xchg.org, hughd@...gle.com,
        jack@...e.cz, josef@...icpanda.com, jrdr.linux@...il.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        sfr@...b.auug.org.au, syzkaller-bugs@...glegroups.com,
        willy@...radead.org
Subject: Re: KASAN: use-after-free Read in filemap_fault

On Fri, Dec 28, 2018 at 01:09:38PM -0800, Andrew Morton wrote:
> On Fri, 28 Dec 2018 12:51:04 -0800 syzbot <syzbot+b437b5a429d680cf2217@...kaller.appspotmail.com> wrote:
> 
> > Hello,
> > 
> > syzbot found the following crash on:
> 
> uh-oh.  Josef, could you please take a look?
> 
> :	page = find_get_page(mapping, offset);
> : 	if (likely(page) && !(vmf->flags & FAULT_FLAG_TRIED)) {
> : 		/*
> : 		 * We found the page, so try async readahead before
> : 		 * waiting for the lock.
> : 		 */
> : 		fpin = do_async_mmap_readahead(vmf, page);
> : 	} else if (!page) {
> : 		/* No page in the page cache at all */
> : 		fpin = do_sync_mmap_readahead(vmf);
> : 		count_vm_event(PGMAJFAULT);
> : 		count_memcg_event_mm(vmf->vma->vm_mm, PGMAJFAULT);
> 
> vmf->vma has been freed at this point.
> 
> : 		ret = VM_FAULT_MAJOR;
> : retry_find:
> : 		page = pagecache_get_page(mapping, offset,
> : 					  FGP_CREAT|FGP_FOR_MMAP,
> : 					  vmf->gfp_mask);
> : 		if (!page) {
> : 			if (fpin)
> : 				goto out_retry;
> : 			return vmf_error(-ENOMEM);
> : 		}
> : 	}
> 

Here's a fixup for "filemap: drop the mmap_sem for all blocking operations".

do_sync_mmap_readahead() drops mmap_sem now, so by the time of
dereferencing vmf->vma for count_memcg_event_mm() the VMA can be gone.

diff --git a/mm/filemap.c b/mm/filemap.c
index 00a9315f45d4..65c85c47bdb1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2554,10 +2554,10 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
 		fpin = do_async_mmap_readahead(vmf, page);
 	} else if (!page) {
 		/* No page in the page cache at all */
-		fpin = do_sync_mmap_readahead(vmf);
 		count_vm_event(PGMAJFAULT);
 		count_memcg_event_mm(vmf->vma->vm_mm, PGMAJFAULT);
 		ret = VM_FAULT_MAJOR;
+		fpin = do_sync_mmap_readahead(vmf);
 retry_find:
 		page = pagecache_get_page(mapping, offset,
 					  FGP_CREAT|FGP_FOR_MMAP,
-- 
 Kirill A. Shutemov