lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181229223033.q4gx4cn7ci6scysr@gmail.com>
Date:   Sat, 29 Dec 2018 12:30:33 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Willy Tarreau <w@....eu>
Cc:     mingo@...nel.org, paulmck@...ux.vnet.ibm.com,
        rdunlap@...radead.org, linux-kernel@...r.kernel.org,
        Joey Pabalinas <joeypabalinas@...il.com>
Subject: Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and
 alignment

On Sat, Dec 29, 2018 at 07:02:17PM +0100, Willy Tarreau wrote:
> A few macros had their rightmost backslash misaligned, and the pollfd
> struct definition resisted the previous code reindent. Nothing else
> changed.
> 
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Willy Tarreau <w@....eu>

Reviewed-by: Joey Pabalinas <joeypabalinas@...il.com>

> ---
>  tools/testing/selftests/rcutorture/bin/nolibc.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/testing/selftests/rcutorture/bin/nolibc.h
> index 30bd27b..985364c 100644
> --- a/tools/testing/selftests/rcutorture/bin/nolibc.h
> +++ b/tools/testing/selftests/rcutorture/bin/nolibc.h
> @@ -81,9 +81,9 @@ typedef   signed long        time_t;
>  
>  /* for poll() */
>  struct pollfd {
> -    int fd;
> -    short int events;
> -    short int revents;
> +	int fd;
> +	short int events;
> +	short int revents;
>  };
>  
>  /* for select() */
> @@ -239,7 +239,7 @@ struct stat {
>  		"syscall\n"                                                   \
>  		: "=a" (_ret)                                                 \
>  		: "0"(_num)                                                   \
> -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
>  	);                                                                    \
>  	_ret;                                                                 \
>  })
> @@ -255,7 +255,7 @@ struct stat {
>  		: "=a" (_ret)                                                 \
>  		: "r"(_arg1),                                                 \
>  		  "0"(_num)                                                   \
> -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
>  	);                                                                    \
>  	_ret;                                                                 \
>  })
> @@ -272,7 +272,7 @@ struct stat {
>  		: "=a" (_ret)                                                 \
>  		: "r"(_arg1), "r"(_arg2),                                     \
>  		  "0"(_num)                                                   \
> -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
>  	);                                                                    \
>  	_ret;                                                                 \
>  })
> @@ -290,7 +290,7 @@ struct stat {
>  		: "=a" (_ret)                                                 \
>  		: "r"(_arg1), "r"(_arg2), "r"(_arg3),                         \
>  		  "0"(_num)                                                   \
> -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
>  	);                                                                    \
>  	_ret;                                                                 \
>  })
> -- 
> 2.9.0
> 

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ