linux-kernel - Re: [PATCH] Staging: vt6655: Fix camel case of variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <117f5de40dabc48457f8725ece6c5b659caff043.camel@perches.com>
Date:   Sat, 29 Dec 2018 15:58:47 -0800
From:   Joe Perches <joe@...ches.com>
To:     Petr Sedlák <hugosedlak@...il.com>,
        Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vt6655: Fix camel case of variable

On Sat, 2018-12-29 at 23:59 +0100, Petr Sedlák wrote:
> Replace variable uDelayUnit with u_delay_unit. Issue found by
> checkpatch.

probably better as a static inline too.

> diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
[]
> @@ -42,15 +42,15 @@
>  #define VNSvOutPortD(dwIOAddress, dwData) \
>  	iowrite32((u32)(dwData), dwIOAddress)
>  
> -#define PCAvDelayByIO(uDelayUnit)				\
> +#define PCAvDelayByIO(u_delay_unit)				\
>  do {								\
>  	unsigned char byData;					\
>  	unsigned long ii;					\
>  								\
> -	if (uDelayUnit <= 50) {					\
> -		udelay(uDelayUnit);				\
> +	if (u_delay_unit <= 50) {					\
> +		udelay(u_delay_unit);				\
>  	} else {						\
> -		for (ii = 0; ii < (uDelayUnit); ii++)		\
> +		for (ii = 0; ii < (u_delay_unit); ii++)		\
>  			byData = inb(0x61);			\
>  	}							\
>  } while (0)

And as the thing is used only once with a #define
with a value less than 50, maybe just
	udelay(CB_DELAY_LOOP_WAIT);
in that one place.