linux-kernel - Re: [PATCH v5 1/2] lib: add crc64 calculation routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Dec 2018 11:57:16 +0800
From:   Coly Li <colyli@...e.de>
To:     NeilBrown <neil@...wn.name>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
        linux-block@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Lyle <mlyle@...e.org>,
        Kent Overstreet <kent.overstreet@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Eric Biggers <ebiggers3@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v5 1/2] lib: add crc64 calculation routines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 12/29/18 10:58 上午, NeilBrown wrote:
> On Thu, Jul 26 2018, Andrew Morton wrote:
> 
>> On Thu, 26 Jul 2018 13:33:51 +0800 Coly Li <colyli@...e.de>
>> wrote:
>> 
>>> This patch adds the re-write crc64 calculation routines for
>>> Linux kernel. The CRC64 polynomial arithmetic follows ECMA-182
>>> specification, inspired by CRC paper of Dr. Ross N. Williams 
>>> (see http://www.ross.net/crc/download/crc_v3.txt) and other
>>> public domain implementations.
> 
> Hi Coly and Andrew,
> 
> This patch breaks compilation if linux headers files are not
> installed (reported at
> https://github.com/gnubee-git/GnuBee_Docs/issues/75). Following
> fixes it.
> 
> Thanks, NeilBrown
> 

Hi Neil,

Thanks for the fix. I add by Acked-by.

Coly Li


> From: NeilBrown <neil@...wn.name> Subject: [PATCH] lib: don't
> depend on linux headers being installed.
> 
> gen_crc64table requires linux include files to be installed in
> /usr/include/linux.  This is a new requrement so hosts that could
> previously build the kernel, now cannot.
> 
> gen_crc64table makes this requirement by including <linux/swab.h>, 
> but nothing from that header is actaully used.
> 
> So remove the #include, so that the linux headers no longer need to
> be installed.
> 
> Fixes: feba04fd2cf8 ("lib: add crc64 calculation routines") 
> Signed-off-by: NeilBrown <neil@...wn.name>

Acked-by: Coly Li <colyli@...e.de>

> --- lib/gen_crc64table.c | 2 -- 1 file changed, 2 deletions(-)
> 
> diff --git a/lib/gen_crc64table.c b/lib/gen_crc64table.c index
> 9011926e4162..094b43aef8db 100644 --- a/lib/gen_crc64table.c +++
> b/lib/gen_crc64table.c @@ -16,8 +16,6 @@ #include <inttypes.h> 
> #include <stdio.h>
> 
> -#include <linux/swab.h> - #define CRC64_ECMA182_POLY
> 0x42F0E1EBA9EA3693ULL
> 
> static uint64_t crc64_table[256] = {0};
> 

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEE6j5FL/T5SGCN6PrQxzkHk2t9+PwFAlwm8JsACgkQxzkHk2t9
+PxELA//U8FohU56Xty9Yfe/5IX0WXHzpLk8efz34xNodo1bavy9yIlpzG8l9cX5
c2vaM4hYvc2rrYokgkxHcANSpFkRzD9TjkwNbij7wd37lEJYzPWr0Qk1Ttuojs7b
iJYLis0pbu6WTeUpM4NwdkKzylqWXg0dRrf3tNpF5ttN+LZOSEzbIiP8P2rnQUmD
a9WCM6Ka/E9dP5H2CIvR6gAJL/BwsVyFgd6PiYy8ElMVYBpIu2uG34eO0tx6ebSE
TPxWrSXY92jWCggJUBNr5zDXyBQADBQfy0YIv36zsplcolF/4mN4LWF2WCC4jp0c
XLBrvSslzombjxq3h+zE4GNXsDNiKtaNQy1N30b1+N3ilXa4uav1wVvaBQBMwf4I
QQDM8ZZ2alS5zAyzgtnbIr0AhlNEya+GO+42+rY0yrWG2Ffg3ONHSgylQ7hANVdk
2qAWugdXZLw/pqustIodIR3hjsWLc4zZDF+d6BywdB5WqSiS54u7ENSPkbGInKRR
8zprb2tjjjgwxL1MXF+6J1HG+GoTvEjjwjh26XDSiFbWCIX3hRjej+EjltKDARIo
RWfX6/hTVnljkNUEpBfsi7DaiDVwkgo1OLQ3OSXgG9rZxs50ASMb4dBuN8wGdRrX
jK3PF5m3ddVxCW2I5CFltd3qHlUFn+fmQojXtU6VSACgw0roQhw=
=qnbZ
-----END PGP SIGNATURE-----